Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update scaffolding sandbox => extensions #1902

Merged
merged 1 commit into from
Aug 3, 2023
Merged

chore: update scaffolding sandbox => extensions #1902

merged 1 commit into from
Aug 3, 2023

Conversation

matejvasek
Copy link
Contributor

Changes

  • 🧹 Update Go scaffolding dependencies with regard to rename knative-sandbox => knative-extensions.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +2.08% 🎉

Comparison is base (f183c92) 60.68% compared to head (6c70494) 62.76%.
Report is 1 commits behind head on main.

❗ Current head 6c70494 differs from pull request most recent head 4ac7b78. Consider uploading reports for the commit 4ac7b78 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1902      +/-   ##
==========================================
+ Coverage   60.68%   62.76%   +2.08%     
==========================================
  Files         107      107              
  Lines       13827    13827              
==========================================
+ Hits         8391     8679     +288     
+ Misses       4606     4266     -340     
- Partials      830      882      +52
Flag Coverage Δ
e2e-test 35.46% <ø> (ø)
e2e-test-oncluster 30.80% <ø> (?)
e2e-test-oncluster-runtime 25.63% <ø> (?)
e2e-test-runtime-go 25.82% <ø> (?)
e2e-test-runtime-node 26.90% <ø> (?)
e2e-test-runtime-python 26.90% <ø> (?)
e2e-test-runtime-quarkus 27.02% <ø> (?)
e2e-test-runtime-springboot 26.04% <ø> (?)
e2e-test-runtime-typescript 27.02% <ø> (?)
integration-tests 51.43% <ø> (+2.11%) ⬆️
unit-tests-macos-latest 48.62% <ø> (ø)
unit-tests-ubuntu-latest 49.38% <ø> (ø)
unit-tests-windows-latest 48.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

upodroid
upodroid approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/override codecov/project

@knative-prow
Copy link

knative-prow bot commented Aug 3, 2023

@upodroid: Overrode contexts on behalf of upodroid: codecov/project

In response to this:

LGTM

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit e13d029 into knative:main Aug 3, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@gauron99 gauron99 Awaiting requested review from gauron99

@navidshaikh navidshaikh Awaiting requested review from navidshaikh

@krsna-m krsna-m Awaiting requested review from krsna-m

@lance lance Awaiting requested review from lance

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matejvasek @upodroid